-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic MockServer integration test for Python #3534
Add a basic MockServer integration test for Python #3534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
it/python/requirements-dev.txt
Outdated
@@ -98,7 +98,7 @@ httpx[http2]==0.25.0 | |||
|
|||
hyperframe==6.0.1 ; python_full_version >= '3.6.1' | |||
|
|||
microsoft-kiota-abstractions==0.9.0 | |||
microsoft-kiota-abstractions==0.8.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this, I believe #3524 is going to fix this issue. (you could rebase onto that branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased
I think something went wrong during the rebase, the history contains a lot of commits and there's currently a conflict. |
yup, fixed now 👍 I'm targeting the I hope this is fine for you and @samwelkanda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOLD merge until #3524 gets merged itself
Sounds good, thanks for explaining! 👍 |
@samwelkanda @baywet I think that something went wrong here ...this should have been rebased, should I open it again? |
interesting, the behaviour between PRs from the same repo and PRs across forks is different. Sorry about the mess here. Yes please do |
There is no "button" to re-open it from UI, I'll open a new PR from a different branch if this works for you |
Reproducer for #3533
and cleaning the camp, since I'm here 🙂